Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #12063 - use less heavy code in executor tests #5566

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

firewave
Copy link
Collaborator

The allocation invokes some heavy ValueFlow computations. We just want to generate an unconditional error from the analysis so use some lighter code which does the same.

TestThreadExecutorFiles::deadlock_with_many_errors

Before:

real    0m23.517s
user    0m33.453s
sys     0m2.297s

After:

real    0m5.051s
user    0m6.234s
sys     0m0.422s

@firewave
Copy link
Collaborator Author

This might fix the random executor test timeouts tracked in https://trac.cppcheck.net/ticket/12063 which might just be actual timeouts since the tests are slow and we might have just encountered a slow runner.

@firewave firewave changed the title use less heavy code in executor tests fixed #12063 - use less heavy code in executor tests Oct 17, 2023
@firewave
Copy link
Collaborator Author

firewave commented Oct 17, 2023

This might fix the random executor test timeouts tracked in https://trac.cppcheck.net/ticket/12063 which might just be actual timeouts since the tests are slow and we might have just encountered a slow runner.

Some before cases:

 48/100 Test  #46: TestProcessExecutorFiles .............   Passed   67.76 sec
 49/100 Test  #47: TestProcessExecutorFS ................   Passed   67.99 sec
 48/100 Test  #46: TestProcessExecutorFiles .............   Passed   76.17 sec
 49/100 Test  #47: TestProcessExecutorFS ................   Passed   76.80 sec
 48/100 Test  #46: TestProcessExecutorFiles .............   Passed   83.89 sec
 49/100 Test  #47: TestProcessExecutorFS ................   Passed   84.90 sec

It appears my assumption might be correct as these are starting to cutting it close to the 90 seconds timeout.

@chrchr-github chrchr-github merged commit b40d36a into danmar:main Oct 17, 2023
74 checks passed
@firewave firewave deleted the exec-test-2 branch October 17, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants