Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/CMakeLists.txt: updated the test fixture costs #5565

Merged
merged 1 commit into from
Oct 21, 2023
+21 −5
Merged

test/CMakeLists.txt: updated the test fixture costs #5565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,26 @@ if (BUILD_TESTS)

# Set cost of the more expensive tests to help improve parallel scheduling
# of tests
fixture_cost(TestIO 20)
fixture_cost(cfg-std_c 8)
fixture_cost(TestThreadExecutor 5)
fixture_cost(TestLeakAutoVarRecursiveCountLimit 4)
fixture_cost(TestTokenizer 4)
#
# To collect data to update this list remove "<cmake-build-folder>/Testing/Temporary/CTestCostData.txt",
# disable the fixture_cost() statements below and run a Debug build with "ctest -j1" several times.
# Afterwards run it with "ctest -j11" and immediately cancel the run and update the list accordingly to the
# first eleven tests chosen.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only the first 11? We should be using the top slowest tests.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is kind of arbitrarily - it was because my machine has 12 threads. I also didn't want to have a list which is too long. But that is also about the amount of tests which run longer than the rest and delivers the desired result with -j2 (what is what we have in the CI).

This should only be applied when using the CI since locally CTest will track the actual times it takes and re-order them. Unfortunately I have seen those costs getting messed up pretty easily so they became useless. That's why I didn't make it optional yet. Still need to file bug reports about it.

#
# NOTE: The TestProcessExecutor* tests are not the slowest but they invoke processes which max out the system
# and negatively impact the run-time of the other tests
if (TRUE)
fixture_cost(TestProcessExecutorFiles 1.10)
fixture_cost(TestProcessExecutorFS 1.09)
fixture_cost(cfg-std_c 1.08)
fixture_cost(TestIO 1.07)
fixture_cost(cfg-std_cpp 1.06)
fixture_cost(TestCondition 1.05)
fixture_cost(TestValueFlow 1.04)
fixture_cost(TestLeakAutoVarRecursiveCountLimit 1.03)
fixture_cost(TestBufferOverrun 1.02)
fixture_cost(TestClass 1.01)
fixture_cost(TestStl 1.00)
endif()
endif()
endif()
Loading