Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid const_cast #5490

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Avoid const_cast #5490

merged 1 commit into from
Sep 28, 2023

Conversation

chrchr-github
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator

If you can we should enable the cppcoreguidelines-pro-type-const-cast clang-tidy warning.

@firewave
Copy link
Collaborator

Also please have a look at #4344. I have not yet checked up on the last comment.

@chrchr-github
Copy link
Collaborator Author

cppcoreguidelines-pro-type-const-cast just flags any const_cast, and we still have some (good and bad).

@chrchr-github chrchr-github merged commit 033cf64 into danmar:main Sep 28, 2023
72 checks passed
@chrchr-github chrchr-github deleted the chr_ccast branch September 28, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrchr-github @firewave