Refactor: The code to generate id string from pointer can be simplified #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmar
commented
Aug 31, 2023
|
Just from taking a quick look this introduces a completely new format. We should at least try to match one of the existing ones - I would go with |
firewave
reviewed
Aug 31, 2023
danmar
force-pushed
the
refactor-dumpfile-id
branch
from
69e9751
to
f7cd4b5
Compare
I see no advantage for a fixed size when it's used as a id string.. fewer bytes means the addons that use cppcheckdata.py will load the dump files a little quicker (there are lots of string comparisons of these id strings as far as I know) and that the dump files will be a little smaller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The id string should just be a unique value. There is no need that this value is equal to the pointer. And there is no requirement to use the same hexadecimal output format as the ostringstream implementation. Therefore the code to generate the id can be simplified.