Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constParameterPointer regression #5361

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

mptre
Copy link
Contributor

@mptre mptre commented Aug 22, 2023

Commit 7325154 ("Fix #11842 FN constParameterPointer with library function (#5257)") most likely introduced a regression for (C) function pointers passed to functions provided by the standard library that cppcheck has knowledge about.

@chrchr-github
Copy link
Collaborator

It would be easier to just remove the direction="in" attribute in std.cfg, see this similar commit: 824f895
I don't know what the direction was originally intended for, but we now use it to check constness for pointer arguments.

Commit 7325154 ("Fix #11842 FN constParameterPointer with library function
(danmar#5257)") most a regression for (C) function pointers passed to functions
provided by the standard library that cppcheck has knowledge about.
@chrchr-github chrchr-github merged commit 73b9442 into danmar:main Aug 23, 2023
72 checks passed
@mptre mptre deleted the const-ptr-regress branch August 23, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants