Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if --cppcheck-build-dir exists #5254

Merged
merged 5 commits into from
Aug 4, 2023

Conversation

samopolacek
Copy link
Contributor

Cppcheck does not report that cppcheck build dir does not exist and also does not report any write issues to the non-existent directory.

This means that cppcheck build dir is actually not used.

We should either create the directory or fail.

@chrchr-github
Copy link
Collaborator

On which platform does this happen? It works fine on Windows.

@samopolacek
Copy link
Contributor Author

I am running cppcheck on Debian 12.

@chrchr-github
Copy link
Collaborator

Upon further review, the directory has to be created beforehand on Windows as well.

@firewave
Copy link
Collaborator

Please add a cli Python unit test for this.

Also this should be implemented via a function in the Path helper class.

@samopolacek samopolacek marked this pull request as draft July 28, 2023 09:30
@samopolacek
Copy link
Contributor Author

samopolacek commented Jul 28, 2023

  • Add a function to Path helper class
  • Add cli UT

@samopolacek samopolacek marked this pull request as ready for review July 28, 2023 12:33
@samopolacek
Copy link
Contributor Author

Please add a cli Python unit test for this.

Also this should be implemented via a function in the Path helper class.

@firewave , done from my side. Not sure what to do with the failing checks. I've already tried to rerun them, but they again failed.

lib/path.cpp Show resolved Hide resolved
@chrchr-github chrchr-github merged commit b2511fb into danmar:main Aug 4, 2023
72 checks passed
@firewave
Copy link
Collaborator

Turns out we already had the functionality implemented in the FileLister. I will get rid of the redundant code.

@samopolacek samopolacek deleted the build_dir_existence branch August 21, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants