moved MyFileInfo definitions into source files
#4697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really see the point. CheckBufferOverrun::MyFileInfo is only supposed to be used in CheckBufferOverrun so it makes sense to hide it in that scope. |
|
There's no need to make these "visible" outside of the class as they are only used internally. As they are private they are obviously not accessible and do not pollute any scopes. But they might require you to add includes to the headers which are necessary. |
firewave
force-pushed
the
check-myfileinfo
branch
4 times, most recently
from
86b2478
to
3081993
Compare
|
well I don't have a strong opinion. |
firewave
force-pushed
the
check-myfileinfo
branch
from
3081993
to
5a72372
Compare
firewave
force-pushed
the
check-myfileinfo
branch
from
5a72372
to
2d8204e
Compare
Maybe the include cleanup helps to get my point across. |
Yes :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.