added and used Timer::run() helper
#4533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a bit awkward in some cases though. I changed all of them because there are few instances and for the sake of consistency. |
firewave
force-pushed
the
timer
branch
2 times, most recently
from
7ed0576
to
d8a60e0
Compare
danmar
approved these changes
Aug 7, 2024
firewave
commented
Aug 7, 2024
| list.createAst(); | ||
| list.validateAst(mSettings.debugnormal); | ||
| } else { | ||
| const SHOWTIME_MODES showTime = mTimerResults ? mSettings.showtime : SHOWTIME_MODES::SHOWTIME_NONE; |
There was a problem hiding this comment.
Pulling this out does not seem to make any sense. I think this might have been left over from when the settings were still a pointer to remove duplicated dereferencing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.