enabled and mitigated modernize-use-equals-default clang-tidy warnings

.clang-tidy

@@ -45,7 +45,6 @@ Checks: >
         -modernize-replace-auto-ptr,
         -modernize-return-braced-init-list,
         -modernize-use-auto,
-        -modernize-use-equals-default,
         -modernize-use-trailing-return-type,
         -performance-avoid-endl,
         -performance-inefficient-string-concatenation,

clang-tidy.md

@@ -63,7 +63,6 @@ This does not appear to be useful as it is reported on very common code.
 
 It was decided not to apply these.
 
-`modernize-use-equals-default`<br/>
 `modernize-loop-convert`<br/>
 
 These might change the behavior of code which might not be intended (need to file an upstream issue)

gui/checkthread.cpp

@@ -86,14 +86,7 @@ static bool executeCommand(std::string exe, std::vector<std::string> args, std::
 CheckThread::CheckThread(ThreadResult &result) :
     mResult(result),
     mCppcheck(result, true, executeCommand)
-{
-    //ctor
-}
-
-CheckThread::~CheckThread()
-{
-    //dtor
-}
+{}
 
 void CheckThread::check(const Settings &settings)
 {

gui/checkthread.h

@@ -46,7 +46,7 @@ class CheckThread : public QThread {
     Q_OBJECT
 public:
     explicit CheckThread(ThreadResult &result);
-    ~CheckThread() override;
+    ~CheckThread() override = default;
 
     /**
      * @brief Set settings for cppcheck

gui/csvreport.cpp

@@ -30,9 +30,6 @@ CsvReport::CsvReport(const QString &filename) :
     Report(filename)
 {}
 
-CsvReport::~CsvReport()
-{}
-
 bool CsvReport::create()
 {
     if (Report::create()) {

gui/csvreport.h

@@ -39,7 +39,7 @@ class ErrorItem;
 class CsvReport : public Report {
 public:
     explicit CsvReport(const QString &filename);
-    ~CsvReport() override;
+    ~CsvReport() override = default;
 
     /**
      * @brief Create the report (file).

gui/printablereport.cpp

@@ -27,9 +27,6 @@ PrintableReport::PrintableReport() :
     Report(QString())
 {}
 
-PrintableReport::~PrintableReport()
-{}
-
 bool PrintableReport::create()
 {
     return true;

gui/printablereport.h

@@ -36,7 +36,7 @@ class ErrorItem;
 class PrintableReport : public Report {
 public:
     PrintableReport();
-    ~PrintableReport() override;
+    ~PrintableReport() override = default;
 
     /**
      * @brief Create the report (file).

lib/timer.h

@@ -37,7 +37,7 @@ enum class SHOWTIME_MODES {
 
 class CPPCHECKLIB TimerResultsIntf {
 public:
-    virtual ~TimerResultsIntf() {}
+    virtual ~TimerResultsIntf() = default;
 
     virtual void addResults(const std::string& str, std::clock_t clocks) = 0;
 };
@@ -54,7 +54,7 @@ struct TimerResultsData {
 
 class CPPCHECKLIB TimerResults : public TimerResultsIntf {
 public:
-    TimerResults() {}
+    TimerResults() = default;
 
     void showResults(SHOWTIME_MODES mode) const;
     void addResults(const std::string& str, std::clock_t clocks) override;