Skip to content

Commit

Permalink
do not run the scheduled GitHub actions or CIFuzz on forks / some sma…
Browse files Browse the repository at this point in the history 
…ll cleanups (#6107)
  • Loading branch information
@firewave
firewave authored Mar 11, 2024
1 parent c5ff68f commit ed64e97
Show file tree
Hide file tree
Showing 10 changed files with 28 additions and 18 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/CI-cygwin.yml.deactivated → .github/workflows/CI-cygwin.yml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Some convenient links:
# - https://github.com/actions/virtual-environments/blob/master/images/win/Windows2019-Readme.md
#

# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions
# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners
name: CI-cygwin

on:
Expand Down Expand Up @@ -34,6 +32,7 @@ jobs:
fail-fast: false

runs-on: ${{ matrix.os }}
if: false # the hard-coded cygwin repository has changed so the setup step fails - TODO: re-enable

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/CI-mingw.yml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Some convenient links:
# - https://github.com/actions/virtual-environments/blob/master/images/win/Windows2019-Readme.md
#

# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions
# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners
name: CI-mingw

on:
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/CI-windows.yml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Some convenient links:
# - https://github.com/actions/virtual-environments/blob/master/images/win/Windows2019-Readme.md
#

# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions
# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners
name: CI-windows

on:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/buildman.yml
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions
# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners
name: Build manual

on:
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/cifuzz.yml
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions
# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners
name: CIFuzz

on: [pull_request]

permissions:
contents: read

jobs:
Fuzzing:
runs-on: ubuntu-latest
if: ${{ github.repository_owner == 'danmar' }}
steps:
- name: Build Fuzzers
id: build
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/codeql-analysis.yml
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions
# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners
name: "CodeQL"

on:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/coverity.yml
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@

# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions
# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners
name: Coverity

on:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/cppcheck-premium.yml
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@

# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions
# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners
name: cppcheck-premium

on:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/iwyu.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
image: ["opensuse/tumbleweed:latest"] # "fedora:latest" / "debian:unstable" / "archlinux:latest"

runs-on: ubuntu-22.04
if: ${{ github.repository_owner == 'danmar' }}

container:
image: ${{ matrix.image }}
Expand Down Expand Up @@ -118,6 +119,7 @@ jobs:
clang-include-cleaner:

runs-on: ubuntu-22.04
if: ${{ github.repository_owner == 'danmar' }}

env:
QT_VERSION: 5.15.2
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/release-windows.yml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Some convenient links:
# - https://github.com/actions/virtual-environments/blob/master/images/win/Windows2019-Readme.md
#

# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions
# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners
name: release-windows

on:
Expand All @@ -24,6 +22,7 @@ jobs:
build:

runs-on: windows-2022
if: ${{ github.repository_owner == 'danmar' }}

env:
# see https://www.pcre.org/original/changelog.txt
Expand Down

4 comments on commit ed64e97

@danmar
Copy link
Owner

@danmar danmar commented on ed64e97 May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@firewave hmm I am not sure about running CI fuzzer on pull requests. It's not deterministic is it?

Cppcheck is registered in the oss-fuzz platform I don't know if it might be better to review that fuzzing.

@danmar
Copy link
Owner

@danmar danmar commented on ed64e97 May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we would like to have a dedicated VM on AWS for fuzzing then please let me know I can probably provide it. I just don't know how we would publish the results..

@firewave
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danmar

Cppcheck is registered in the oss-fuzz platform I don't know if it might be better to review that fuzzing.

CIFuzz is OSS-Fuzz. It is a n GitHub action to detect potential fuzzing failure within the scope of a commit/PR so the potential issue will never be merged in the first place.

If we would like to have a dedicated VM on AWS for fuzzing then please let me know I can probably provide it. I just don't know how we would publish the results..

No need for that because it is provided by the OSS-Fuzz project. They are publishing the results and they are visible to everybody.

We should fix our fuzzing though but I wanted to make sure the issues detected during simple local runs are fixed first because we pull the trigger on that so we do not get swamped with OSS-Fuzz reports immediate. I also lack the permissions to look at the actual payload attached to the reports so right you would be the one to transfer the detected issues into Trac.

@danmar
Copy link
Owner

@danmar danmar commented on ed64e97 May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix our fuzzing though but I wanted to make sure the issues detected during simple local runs are fixed first because we pull the trigger on that so we do not get swamped with OSS-Fuzz reports immediate.

ok. But well it is not deterministic right? Rerunning the fuzzer a second time could make it green. Or could expose a different bug.

I also lack the permissions to look at the actual payload attached to the reports so right you would be the one to transfer the detected issues into Trac.

I can transfer the reports but I think it would be best if others have the permission also.

I also lack the permissions to look at the actual payload attached to the reports so right you would be the one to transfer the detected issues into Trac.

Please sign in to comment.