Fix #11802 FP stlcstr for string in shared_ptr copied elsewhere

danmar · Jul 10, 2023 · b5eb769 · b5eb769
1 parent cc38ef4
commit b5eb769
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/checkstl.cpp b/lib/checkstl.cpp
@@ -2054,7 +2054,7 @@ void CheckStl::string_c_str()
                         if (Token::Match(refTok, "%var% = %var% .|;|["))
                             refToNonLocal = !isLocal(refTok->tokAt(2));
                     }
-                    ptrOrRef = refToNonLocal || (tok2->variable() && tok2->variable()->isPointer());
+                    ptrOrRef = refToNonLocal || (tok2->variable() && (tok2->variable()->isPointer() || tok2->variable()->isSmartPointer()));
                 }
                 while (tok2) {
                     if (Token::Match(tok2, "%var% .|::")) {

diff --git a/test/teststl.cpp b/test/teststl.cpp
@@ -4261,6 +4261,15 @@ class TestStl : public TestFixture {
               "    std::string_view sv(s.data(), 13);\n"
               "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        check("struct S { std::string x; };\n" // #11802
+              "std::vector<std::shared_ptr<S>> global;\n"
+              "const char* f() {\n"
+              "    auto s = std::make_shared<S>();\n"
+              "    global.push_back(s);\n"
+              "    return s->x.c_str();\n"
+              "}\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void uselessCalls() {