fixed some "Parameter can be made pointer/reference to const" Rider w…

…arnings (#5680)
danmar · Nov 20, 2023 · 92c089d · 92c089d
1 parent cd21918
commit 92c089d
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 9 deletions.
diff --git a/gui/codeeditor.cpp b/gui/codeeditor.cpp
@@ -420,7 +420,7 @@ void CodeEditor::highlightErrorLine()
     setExtraSelections(extraSelections);
 }
 
-void CodeEditor::lineNumberAreaPaintEvent(QPaintEvent *event)
+void CodeEditor::lineNumberAreaPaintEvent(const QPaintEvent *event)
 {
     QPainter painter(mLineNumberArea);
     painter.fillRect(event->rect(), mWidgetStyle->lineNumBGColor);

diff --git a/gui/codeeditor.h b/gui/codeeditor.h
@@ -91,7 +91,7 @@ class CodeEditor : public QPlainTextEdit {
     CodeEditor &operator=(const CodeEditor &) = delete;
     ~CodeEditor() override;
 
-    void lineNumberAreaPaintEvent(QPaintEvent *event);
+    void lineNumberAreaPaintEvent(const QPaintEvent *event);
     int lineNumberAreaWidth();
     void setStyle(const CodeEditorStyle& newStyle);
 

diff --git a/gui/cppchecklibrarydata.cpp b/gui/cppchecklibrarydata.cpp
@@ -453,7 +453,7 @@ static CppcheckLibraryData::Markup loadMarkup(QXmlStreamReader &xmlReader)
     return markup;
 }
 
-static CppcheckLibraryData::Entrypoint loadEntrypoint(QXmlStreamReader &xmlReader)
+static CppcheckLibraryData::Entrypoint loadEntrypoint(const QXmlStreamReader &xmlReader)
 {
     CppcheckLibraryData::Entrypoint entrypoint;
     entrypoint.name = xmlReader.attributes().value("name").toString();

diff --git a/gui/settingsdialog.cpp b/gui/settingsdialog.cpp
@@ -214,7 +214,7 @@ void SettingsDialog::saveSettingValues() const
     CodeEditorStyle::saveSettings(&settings, *mCurrentStyle);
 }
 
-void SettingsDialog::saveCheckboxValue(QSettings *settings, QCheckBox *box,
+void SettingsDialog::saveCheckboxValue(QSettings *settings, const QCheckBox *box,
                                        const QString &name)
 {
     settings->setValue(name, checkStateToBool(box->checkState()));

diff --git a/gui/settingsdialog.h b/gui/settingsdialog.h
@@ -185,7 +185,7 @@ protected slots:
      * @param box checkbox to save
      * @param name name for QSettings to store the value
      */
-    static void saveCheckboxValue(QSettings *settings, QCheckBox *box, const QString &name);
+    static void saveCheckboxValue(QSettings *settings, const QCheckBox *box, const QString &name);
 
     /**
      * @brief Convert bool to Qt::CheckState

diff --git a/tools/triage/mainwindow.cpp b/tools/triage/mainwindow.cpp
@@ -285,7 +285,7 @@ bool MainWindow::unpackArchive(const QString &archiveName)
     return runProcess("tar", args);
 }
 
-void MainWindow::showResult(QListWidgetItem *item)
+void MainWindow::showResult(const QListWidgetItem *item)
 {
     ui->statusBar->clearMessage();
     const bool local = item->text().startsWith(DACA2_PACKAGES);

diff --git a/tools/triage/mainwindow.h b/tools/triage/mainwindow.h
@@ -47,7 +47,7 @@ public slots:
     void loadFile();
     void loadFromClipboard();
     void filter(const QString& filter);
-    void showResult(QListWidgetItem *item);
+    void showResult(const QListWidgetItem *item);
     void refreshResults();
     void fileTreeFilter(const QString &str);
     void findInFilesClicked();

diff --git a/tools/triage/mainwindow.ui b/tools/triage/mainwindow.ui
@@ -450,7 +450,7 @@
    <sender>results</sender>
    <signal>itemDoubleClicked(QListWidgetItem*)</signal>
    <receiver>MainWindow</receiver>
-   <slot>showResult(QListWidgetItem*)</slot>
+   <slot>showResult(const QListWidgetItem*)</slot>
    <hints>
     <hint type="sourcelabel">
      <x>28</x>
@@ -481,7 +481,7 @@
  </connections>
  <slots>
   <slot>loadFile()</slot>
-  <slot>showResult(QListWidgetItem*)</slot>
+  <slot>showResult(const QListWidgetItem*)</slot>
   <slot>loadFromClipboard()</slot>
   <slot>filter(QString)</slot>
   <slot>refreshResults()</slot>