Fix #12624 (The misra-config should not be a critical error)

danmar · Apr 18, 2024 · 8d39898 · 8d39898
1 parent 8c78869
commit 8d39898
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/errorlogger.cpp b/lib/errorlogger.cpp
@@ -47,7 +47,6 @@ const std::set<std::string> ErrorLogger::mCriticalErrorIds{
     "internalAstError",
     "instantiationError",
     "internalError",
-    "misra-config",
     "premium-internalError",
     "premium-invalidArgument",
     "premium-invalidLicense",

diff --git a/test/testerrorlogger.cpp b/test/testerrorlogger.cpp
@@ -65,6 +65,8 @@ class TestErrorLogger : public TestFixture {
 
         TEST_CASE(substituteTemplateFormatStatic);
         TEST_CASE(substituteTemplateLocationStatic);
+
+        TEST_CASE(isCriticalErrorId);
     }
 
     void TestPatternSearchReplace(const std::string& idPlaceholder, const std::string& id) const {
@@ -519,6 +521,11 @@ class TestErrorLogger : public TestFixture {
             ASSERT_EQUALS("{", s);
         }
     }
+
+    void isCriticalErrorId() {
+        // It does not abort all the analysis of the file. Like "missingInclude" there can be false negatives.
+        ASSERT_EQUALS(false, ErrorLogger::isCriticalErrorId("misra-config"));
+    }
 };
 
 REGISTER_TEST(TestErrorLogger)