Fix #12313 FP mallocOnClassWarning when malloc'd pointer is passed to…

… implicit conversion (#6019)
danmar · Feb 22, 2024 · 8d079f2 · 8d079f2
1 parent 5b8ddaf
commit 8d079f2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -1429,7 +1429,7 @@ void CheckClass::checkMemset()
                     const std::set<const Scope *> parsedTypes;
                     checkMemsetType(scope, tok, type, false, parsedTypes);
                 }
-            } else if (tok->variable() && tok->variable()->typeScope() && Token::Match(tok, "%var% = %name% (")) {
+            } else if (tok->variable() && tok->variable()->isPointer() && tok->variable()->typeScope() && Token::Match(tok, "%var% = %name% (")) {
                 const Library::AllocFunc* alloc = mSettings->library.getAllocFuncInfo(tok->tokAt(2));
                 if (!alloc)
                     alloc = mSettings->library.getReallocFuncInfo(tok->tokAt(2));

diff --git a/test/testclass.cpp b/test/testclass.cpp
@@ -3598,6 +3598,15 @@ class TestClass : public TestFixture {
                       "    AutoCloseFD fd = open(\"abc\", O_RDONLY | O_CLOEXEC);\n"
                       "}");
         ASSERT_EQUALS("", errout.str());
+
+        checkNoMemset("struct C {\n" // #12313
+                      "    char* p;\n"
+                      "    C(char* ptr) : p(ptr) {}\n"
+                      "};\n"
+                      "void f() {\n"
+                      "    C c = strdup(\"abc\");\n"
+                      "}");
+        ASSERT_EQUALS("", errout.str());
     }
 
 #define checkThisSubtraction(code) checkThisSubtraction_(code, __FILE__, __LINE__)