Fix #12082 FP uninitvar for assignment to array member in conditional

danmar · Oct 18, 2023 · 8bb4b1a · 8bb4b1a
1 parent 9329772
commit 8bb4b1a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/astutils.cpp b/lib/astutils.cpp
@@ -3232,6 +3232,8 @@ static ExprUsage getFunctionUsage(const Token* tok, int indirect, const Settings
         if (!args.empty() && indirect == 0 && !addressOf)
             return ExprUsage::Used;
     } else if (ftok->isControlFlowKeyword()) {
+        if (Token::simpleMatch(ftok->astParent(), "(") && Token::simpleMatch(ftok->astParent()->astOperand2(), "="))
+            return ExprUsage::Inconclusive;
         return ExprUsage::Used;
     } else if (ftok->str() == "{") {
         return indirect == 0 ? ExprUsage::Used : ExprUsage::Inconclusive;

diff --git a/test/testuninitvar.cpp b/test/testuninitvar.cpp
@@ -6288,7 +6288,14 @@ class TestUninitVar : public TestFixture {
                         "    int &q = s;\n"
                         "    foo(q);\n"
                         "}\n");
-        ASSERT_EQUALS("[test.cpp:9]: (error) Uninitialized variable: q\n", errout.str());
+        ASSERT_EQUALS("[test.cpp:9]: (error) Uninitialized variable: q\n", errout.str());        
+
+        valueFlowUninit("int g();\n" // #12082
+                        "void f() {\n"
+                        "    int a[1];\n"
+                        "    while (a[0] = g()) {}\n"
+                        "}");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void valueFlowUninitBreak() { // Do not show duplicate warnings about the same uninitialized value