Fix #12498 FP memleak with getline() and array (#6108)

danmar · Mar 10, 2024 · 866619c · 866619c
1 parent 343b749
commit 866619c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/cfg/posix.cfg b/cfg/posix.cfg
@@ -5237,7 +5237,7 @@ The function 'mktemp' is considered to be dangerous due to race conditions and s
     <arg nr="2" direction="inout">
       <not-null/>
     </arg>
-    <arg nr="3" direction="in">
+    <arg nr="3" direction="inout">
       <not-null/>
       <not-uninit/>
     </arg>

diff --git a/lib/checkleakautovar.cpp b/lib/checkleakautovar.cpp
@@ -985,7 +985,8 @@ void CheckLeakAutoVar::functionCall(const Token *tokName, const Token *tokOpenin
         while (Token::Match(arg, "%name% .|:: %name%"))
             arg = arg->tokAt(2);
 
-        if (Token::Match(arg, "%var% [-,)] !!.") || Token::Match(arg, "& %var% !!.")) {
+        if ((Token::Match(arg, "%var% [-,)] !!.") && !(arg->variable() && arg->variable()->isArray())) ||
+            (Token::Match(arg, "& %var% !!.") && !(arg->next()->variable() && arg->next()->variable()->isArray()))) {
             // goto variable
             const bool isAddressOf = arg->str() == "&";
             if (isAddressOf)

diff --git a/test/cfg/posix.c b/test/cfg/posix.c
@@ -1070,6 +1070,15 @@ void memleak_getline() { // #11043
     line = NULL;
 }
 
+void memleak_getline_array(FILE* stream) { // #12498
+    char* a[2] = { 0 };
+    size_t n;
+    getline(&a[0], &n, stream);
+    getline(&a[1], &n, stream);
+    free(a[0]);
+    free(a[1]);
+}
+
 void * identicalCondition_mmap(int fd, size_t size) // #9940
 {
     void* buffer = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);