Skip to content

Commit

Permalink
Restoring TODO and fixing whitespace
Browse files Browse the repository at this point in the history
  • Loading branch information
Felix Faber committed Apr 19, 2024
1 parent 8e816e5 commit 84a2152
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions lib/importproject.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ bool ImportProject::importSln(std::istream &istr, const std::string &path, const
std::vector<SharedItemsProject> sharedItemsProjects{};
while (std::getline(istr,line)) {
if (!startsWith(line,"Project("))
continue;
continue;
const std::string::size_type pos = line.find(".vcxproj");
if (pos == std::string::npos)
continue;
Expand Down Expand Up @@ -773,7 +773,9 @@ bool ImportProject::importVcxproj(const std::string &filename, std::map<std::str
}
}
}
}
}
// # TODO: support signedness of char via /J (and potential XML option for it)?
// we can only set it globally but in this context it needs to be treated per file

// Include shared items project files
std::vector<std::string> sharedItemsIncludePaths{};
Expand Down Expand Up @@ -806,7 +808,7 @@ bool ImportProject::importVcxproj(const std::string &filename, std::map<std::str
FileSettings fs;
fs.filename = cfilename;
fs.cfg = p.name;
// TODO: detect actual MSC version
// TODO: detect actual MSC version
fs.msc = true;
fs.useMfc = useOfMfc;
fs.defines = "_WIN32=1";
Expand Down

0 comments on commit 84a2152

Please sign in to comment.