avoid duplicated evaluation in `ProgramMemoryState::removeModifiedVar…

…s()` (#6628) Co-authored-by: Paul Fultz II <[email protected]>
danmar · Jul 26, 2024 · 8368943 · 8368943
1 parent dc3ec3f
commit 8368943
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/programmemory.cpp b/lib/programmemory.cpp
@@ -505,9 +505,11 @@ void ProgramMemoryState::removeModifiedVars(const Token* tok)
 {
     const ProgramMemory& pm = state;
     auto eval = [&](const Token* cond) -> std::vector<MathLib::bigint> {
-        if (conditionIsTrue(cond, pm, *settings))
+        ProgramMemory pm2 = pm;
+        auto result = execute(cond, pm2, *settings);
+        if (isTrue(result))
             return {1};
-        if (conditionIsFalse(cond, pm, *settings))
+        if (isFalse(result))
             return {0};
         return {};
     };