Fix #10052 FP parameter can be const (operator()) (#6063)

danmar · Mar 2, 2024 · 7efe35a · 7efe35a
1 parent 976bd48
commit 7efe35a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/astutils.cpp b/lib/astutils.cpp
@@ -2669,6 +2669,8 @@ bool isVariableChanged(const Token *tok, int indirect, const Settings *settings,
         ftok = ftok->astParent();
 
     if (ftok && Token::Match(ftok->link(), ")|} !!{")) {
+        if (ftok->str() == "(" && Token::simpleMatch(ftok->astOperand1(), "[")) // operator() on array element, bail out
+            return true;
         const Token * ptok = tok2;
         while (Token::Match(ptok->astParent(), ".|::|["))
             ptok = ptok->astParent();

diff --git a/test/testother.cpp b/test/testother.cpp
@@ -3544,6 +3544,14 @@ class TestOther : public TestFixture {
               "    const S& s(str);\n"
               "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        check("struct C {\n" // #10052
+              "    int& operator()(int);\n"
+              "};\n"
+              "void f(std::vector<C>& c) {\n"
+              "    c[0](5) = 12;\n"
+              "}\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void constParameterCallback() {