fixup! fixup! fixup! fixup! fixup! fixup! Truncate value of increment…

… operator
danmar · Apr 30, 2024 · 7d7d1ed · 7d7d1ed
1 parent 62c427e
commit 7d7d1ed
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -606,9 +606,7 @@ static ValueFlow::Value truncateImplicitConversion(Token* parent, const ValueFlo
 
 static long long truncateIntValue(long long value, size_t value_size, const ValueType::Sign dst_sign)
 {
-    MathLib::biguint unsignedMaxValue = -1;
-    if (value_size < sizeof(MathLib::biguint))
-        unsignedMaxValue ^= ~(unsignedMaxValue << (value_size * 8));
+    const MathLib::biguint unsignedMaxValue = std::numeric_limits<decltype(unsignedMaxValue)>::max() >> ((sizeof(unsignedMaxValue) - value_size) * 8);
     const MathLib::biguint signBit = 1ULL << (value_size * 8 - 1);
     value &= unsignedMaxValue;
     if (dst_sign == ValueType::Sign::SIGNED && (value & signBit))