Minor: fix msvc warning "not all control paths return a value"

Moved __has_cpp_attribute block up to first choice. When we have a portable standard way of expressing it, that's the best choice. (Addresses Review Feedback from Firewave)
danmar · Nov 12, 2023 · 7bcdf4a · 7bcdf4a
1 parent 9d2d226
commit 7bcdf4a
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/lib/config.h b/lib/config.h
@@ -51,19 +51,21 @@
 #endif
 
 // C++11 noreturn
-#if (defined(__GNUC__) && (__GNUC__ >= 5)) \
-    || defined(__clang__) \
-    || defined(__CPPCHECK__)
-#  define NORETURN [[noreturn]]
-#elif defined(__GNUC__)
-#  define NORETURN __attribute__((noreturn))
-#elif defined __has_cpp_attribute
+#if defined __has_cpp_attribute
 #  if __has_cpp_attribute (noreturn)
 #    define NORETURN [[noreturn]]
 #  endif
 #endif
 #if !defined(NORETURN)
-#  define NORETURN
+#  if (defined(__GNUC__) && (__GNUC__ >= 5)) \
+      || defined(__clang__) \
+      || defined(__CPPCHECK__)
+#    define NORETURN [[noreturn]]
+#  elif defined(__GNUC__)
+#    define NORETURN __attribute__((noreturn))
+#  else
+#    define NORETURN
+#  endif
 #endif
 
 // fallthrough