Fix #12374 FP duplInheritedMember with template in namespace

danmar · Feb 15, 2024 · 775cf85 · 775cf85
1 parent d145f9c
commit 775cf85
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -3013,6 +3013,8 @@ static std::vector<DuplMemberFuncInfo> getDuplInheritedMemberFunctionsRecursive(
         for (const Function& classFuncIt : typeCurrent->classScope->functionList) {
             if (classFuncIt.isImplicitlyVirtual())
                 continue;
+            if (classFuncIt.hasFinalSpecifier())
+                continue;
             for (const Function& parentClassFuncIt : parentClassIt.type->classScope->functionList) {
                 if (classFuncIt.name() == parentClassFuncIt.name() &&
                     (parentClassFuncIt.access != AccessControl::Private || !skipPrivate) &&

diff --git a/test/testclass.cpp b/test/testclass.cpp
@@ -726,6 +726,19 @@ class TestClass : public TestFixture {
                                   "    void Two() = delete;\n"
                                   "};\n");
         ASSERT_EQUALS("", errout.str());
+
+        checkDuplInheritedMembers("namespace N {\n" // #12374
+                                  "    template<typename T>\n"
+                                  "    struct B {\n"
+                                  "        std::unique_ptr<B<T>> clone() const = 0;\n"
+                                  "    };\n"
+                                  "    struct D : public B<int> {\n"
+                                  "        std::unique_ptr<B<int>> clone() const final {\n"
+                                  "            return std::make_unique<D>(*this);\n"
+                                  "        }\n"
+                                  "    };\n"
+                                  "}\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
 #define checkCopyConstructor(code) checkCopyConstructor_(code, __FILE__, __LINE__)