Fix #12390 FP selfAssignment for unknown struct member (#5924)

danmar · Jan 31, 2024 · 593cf5f · 593cf5f
1 parent d6bca49
commit 593cf5f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/astutils.cpp b/lib/astutils.cpp
@@ -2955,7 +2955,7 @@ static const Token* findExpressionChangedImpl(const Token* expr,
             global = true;
         }
 
-        if (tok->exprId() > 0) {
+        if (tok->exprId() > 0 || global) {
             const Token* modifedTok = find(start, end, [&](const Token* tok2) {
                 int indirect = 0;
                 if (const ValueType* vt = tok->valueType()) {

diff --git a/test/testother.cpp b/test/testother.cpp
@@ -5619,6 +5619,14 @@ class TestOther : public TestFixture {
               "    i = b[idx];\n"
               "};\n");
         ASSERT_EQUALS("", errout.str());
+
+        check("void g(int*);\n" // #12390
+              "void f() {\n"
+              "    int o = s.i;\n"
+              "    g(&s.i);\n"
+              "    s.i = o;\n"
+              "}\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void trac1132() {