Fix FN constParameterReference

danmar · Mar 5, 2024 · 4da68b4 · 4da68b4
1 parent 14833a4
commit 4da68b4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 18 deletions.
diff --git a/lib/checkother.cpp b/lib/checkother.cpp
@@ -1333,20 +1333,6 @@ void CheckOther::passedByValueError(const Variable* var, bool inconclusive, bool
     reportError(errorPath, Severity::performance, id.c_str(), msg, CWE398, inconclusive ? Certainty::inconclusive : Certainty::normal);
 }
 
-static bool isUnusedVariable(const Variable *var)
-{
-    if (!var)
-        return false;
-    if (!var->scope())
-        return false;
-    const Token *start = var->declEndToken();
-    if (!start)
-        return false;
-    if (Token::Match(start, "; %varid% =", var->declarationId()))
-        start = start->tokAt(2);
-    return !Token::findmatch(start->next(), "%varid%", var->scope()->bodyEnd, var->declarationId());
-}
-
 static bool isVariableMutableInInitializer(const Token* start, const Token * end, nonneg int varid)
 {
     if (!start)
@@ -1402,8 +1388,6 @@ void CheckOther::checkConstVariable()
         if (function && var->isArgument()) {
             if (function->isImplicitlyVirtual() || function->templateDef)
                 continue;
-            if (isUnusedVariable(var))
-                continue;
             if (function->isConstructor() && isVariableMutableInInitializer(function->constructorMemberInitialization(), scope->bodyStart, var->declarationId()))
                 continue;
         }

diff --git a/test/testother.cpp b/test/testother.cpp
@@ -2576,11 +2576,15 @@ class TestOther : public TestFixture {
               "}");
         ASSERT_EQUALS("", errout.str());
 
-        // Perhaps unused variable should be checked as well.
         check("void f(int& x, int& y) {\n"
               "    y++;\n"
               "}");
-        ASSERT_EQUALS("", errout.str());
+        ASSERT_EQUALS("[test.cpp:1]: (style) Parameter 'x' can be declared as reference to const\n", errout.str());
+
+        check("int f(int& t) {\n" // #11713
+              "    return 0;\n"
+              "}\n");
+        ASSERT_EQUALS("[test.cpp:1]: (style) Parameter 't' can be declared as reference to const\n", errout.str());
 
         check("struct A {\n"
               "    explicit A(int& y) : x(&y) {}\n"