Fix

danmar · Jun 12, 2024 · 3fa0515 · 3fa0515
1 parent 86837c5
commit 3fa0515
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/checkunusedfunctions.cpp b/lib/checkunusedfunctions.cpp
@@ -250,13 +250,15 @@ void CheckUnusedFunctions::parseTokens(const Tokenizer &tokenizer, const Setting
         }
 
         if (funcname) {
+            if (isRecursiveCall(funcname))
+                continue;
             const auto baseName = stripTemplateParameters(funcname->str());
             FunctionUsage &func = mFunctions[baseName];
             const std::string& called_from_file = tokenizer.list.getFiles()[funcname->fileIndex()];
 
             if (func.filename.empty() || func.filename == "+" || func.filename != called_from_file)
                 func.usedOtherFile = true;
-            else if (!isRecursiveCall(funcname))
+            else
                 func.usedSameFile = true;
 
             mFunctionCalls.insert(baseName);

diff --git a/test/testunusedfunctions.cpp b/test/testunusedfunctions.cpp
@@ -181,7 +181,7 @@ class TestUnusedFunctions : public TestFixture {
               "    if (cond) ;\n"
               "    else f1();\n"
               "}");
-        ASSERT_EQUALS("[test.cpp:1]: (style) The function 'foo' is never used.\n", errout_str());
+        ASSERT_EQUALS("[test.cpp:1]: (style) The function 'f1' is never used.\n", errout_str());
     }
 
     void functionpointer() {