Fix #12536 FP uninitvar for unused reference (#6259)

danmar · Apr 9, 2024 · 3ad4533 · 3ad4533
1 parent fe45744
commit 3ad4533
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/astutils.cpp b/lib/astutils.cpp
@@ -3305,6 +3305,7 @@ static ExprUsage getFunctionUsage(const Token* tok, int indirect, const Settings
                         return ExprUsage::PassedByReference;
                     }
                 }
+                return ExprUsage::NotUsed;
             }
         }
         if (!args.empty() && indirect == 0 && !addressOf)

diff --git a/test/testuninitvar.cpp b/test/testuninitvar.cpp
@@ -4345,6 +4345,13 @@ class TestUninitVar : public TestFixture {
                         "  a = item.a;\n"
                         "}", "test.c");
         ASSERT_EQUALS("", errout_str());
+
+        valueFlowUninit("void f(int& r) {}\n" // #12536
+                        "void g() {\n"
+                        "    int i;\n"
+                        "    f(i);\n"
+                        "}");
+        ASSERT_EQUALS("", errout_str());
     }
 
     void uninitStructMember() { // struct members