Fix #12172:False positive: misra-11.1 function pointer assigned to array

danmar · Nov 15, 2023 · 39dd29f · 39dd29f
1 parent 282c195
commit 39dd29f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/addons/misra.py b/addons/misra.py
@@ -647,7 +647,8 @@ def get_function_pointer_type(tok):
     ret += '('
     tok = tok.next.next
     while tok and (tok.str not in '()'):
-        ret += ' ' + tok.str
+        if tok.varId is None:
+            ret += ' ' + tok.str
         tok = tok.next
     if (tok is None) or tok.str != ')':
         return None

diff --git a/addons/test/misra/misra-test.c b/addons/test/misra/misra-test.c
@@ -779,6 +779,13 @@ static void misra_10_8(u8 x, s32 a, s32 b) {
 int (*misra_11_1_p)(void); // 8.4
 void *misra_11_1_bad1 = (void*)misra_11_1_p; // 11.1 8.4
 
+// #12172
+typedef void (*pfFunc)(uint32_t some);
+extern pfFunc data[10];
+void f(pfFunc ptr){ //8.4
+    data[index] = ptr;
+}
+
 struct misra_11_2_s;
 struct misra_11_2_t;