enabled and mitigated performance-noexcept-swap clang-tidy warnings

danmar · Aug 12, 2024 · 377a916 · 377a916
1 parent 11df5ae
commit 377a916
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -56,7 +56,6 @@ Checks: >
         -performance-avoid-endl,
         -performance-inefficient-string-concatenation,
         -performance-no-automatic-move,
-        -performance-noexcept-swap,
         -portability-simd-intrinsics,
         -portability-std-allocator-const,
         -readability-avoid-const-params-in-decls,

diff --git a/clang-tidy.md b/clang-tidy.md
@@ -122,7 +122,6 @@ We run this separately via `clang-include-cleaner` in the `iwyu.yml` workflow as
 `concurrency-mt-unsafe`<br/>
 `misc-use-anonymous-namespace`<br/>
 `performance-avoid-endl`<br/>
-`performance-noexcept-swap`<br/>
 `bugprone-switch-missing-default-case`<br/>
 `bugprone-empty-catch`<br/>
 `readability-avoid-nested-conditional-operator`<br/>

diff --git a/gui/cppchecklibrarydata.h b/gui/cppchecklibrarydata.h
@@ -19,6 +19,8 @@
 #ifndef CPPCHECKLIBRARYDATA_H
 #define CPPCHECKLIBRARYDATA_H
 
+#include "config.h"
+
 #include <cstdint>
 
 #include <QList>
@@ -227,7 +229,7 @@ class CppcheckLibraryData {
         entrypoints.clear();
     }
 
-    void swap(CppcheckLibraryData &other) {
+    void swap(CppcheckLibraryData &other) NOEXCEPT {
         containers.swap(other.containers);
         defines.swap(other.defines);
         undefines.swap(other.undefines);