Skip to content

Commit

Permalink
gui/mainwindow.cpp: use picojson to generate JSON / updated picojson …
Browse files Browse the repository at this point in the history 
…to latest dev version (#5710)

The lastest release of picojson does not support creation of JSONs, so
we need to switch to the current dev version.
  • Loading branch information
@firewave
firewave committed Dec 5, 2023
1 parent 70745b5 commit 347b188
Show file tree
Hide file tree
Showing 4 changed files with 1,009 additions and 812 deletions.
Loading

4 comments on commit 347b188

@firewave
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danmar Looking into the test failures.

I have no idea why it reports a different line now when the PR build passed. I also had it report the issue at line 2 locally at the very beginning but that changed to line 1 and I thought I just had a typo in a test. Seems like something fishy is going on.

@firewave
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. The output changed because of the library update and the tests were introduced with #5712 which were not part of the CI.

@firewave
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by #5729.

@danmar
Copy link
Owner

@danmar danmar commented on 347b188 Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!!

Please sign in to comment.