Fix #12443 FP mismatchingContainers with container in namespace

danmar · Feb 14, 2024 · 20e56c5 · 20e56c5
1 parent d145f9c
commit 20e56c5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/checkstl.cpp b/lib/checkstl.cpp
@@ -690,6 +690,8 @@ static std::vector<const Token*> getAddressContainer(const Token* tok)
 {
     if (Token::simpleMatch(tok, "[") && tok->astOperand1())
         return { tok->astOperand1() };
+    while (Token::simpleMatch(tok, "::") && tok->astOperand2())
+        tok = tok->astOperand2();
     std::vector<ValueFlow::Value> values = ValueFlow::getLifetimeObjValues(tok, /*inconclusive*/ false);
     std::vector<const Token*> res;
     for (const auto& v : values) {

diff --git a/test/teststl.cpp b/test/teststl.cpp
@@ -2204,6 +2204,16 @@ class TestStl : public TestFixture {
               "    a.erase(*it);\n"
               "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        check("namespace N {\n" // #12443
+              "    std::vector<int> v;\n"
+              "}\n"
+              "using namespace N;\n"
+              "void f() {\n"
+              "    auto it = std::find(v.begin(), v.end(), 0);\n"
+              "    if (it != N::v.end()) {}\n"
+              "}\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void eraseIteratorOutOfBounds() {