Fix #11890 FP uninitvar for address taken in init list

danmar · Aug 22, 2023 · 10b7fd5 · 10b7fd5
1 parent 59c3bd2
commit 10b7fd5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/astutils.cpp b/lib/astutils.cpp
@@ -3148,7 +3148,7 @@ static ExprUsage getFunctionUsage(const Token* tok, int indirect, const Settings
     } else if (ftok->isControlFlowKeyword()) {
         return ExprUsage::Used;
     } else if (ftok->str() == "{") {
-        return ExprUsage::Used;
+        return indirect == 0 ? ExprUsage::Used : ExprUsage::Inconclusive;
     } else {
         const bool isnullbad = settings->library.isnullargbad(ftok, argnr + 1);
         if (indirect == 0 && astIsPointer(tok) && !addressOf && isnullbad)

diff --git a/test/testuninitvar.cpp b/test/testuninitvar.cpp
@@ -6197,6 +6197,12 @@ class TestUninitVar : public TestFixture {
                         "    x = i;\n"
                         "}\n");
         ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: i\n", errout.str());
+
+        valueFlowUninit("void f() {\n" // #11890
+                        "    int x;\n"
+                        "    int* a[] = { &x };\n"
+                        "}\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void valueFlowUninitBreak() { // Do not show duplicate warnings about the same uninitialized value