bail out early on empty library in CLI

danmar · Jul 15, 2024 · 0ce4f3b · 0ce4f3b
1 parent 48704ee
commit 0ce4f3b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/cli/cmdlineparser.cpp b/cli/cmdlineparser.cpp
@@ -870,9 +870,12 @@ CmdLineParser::Result CmdLineParser::parseFromArgs(int argc, const char* const a
 
             // --library
             else if (std::strncmp(argv[i], "--library=", 10) == 0) {
-                // TODO: bail out on empty library
                 std::list<std::string> libs = splitString(argv[i] + 10, ',');
                 for (auto& l : libs) {
+                    if (l.empty()) {
+                        mLogger.printError("empty library specified.");
+                        return Result::Fail;
+                    }
                     mSettings.libraries.emplace_back(std::move(l));
                 }
             }

diff --git a/test/testcmdlineparser.cpp b/test/testcmdlineparser.cpp
@@ -2464,14 +2464,14 @@ class TestCmdlineParser : public TestFixture {
         REDIRECT;
         const char * const argv[] = {"cppcheck", "--library=posix,,gnu", "file.cpp"};
         ASSERT_EQUALS(false, parser->fillSettingsFromArgs(3, argv));
-        ASSERT_EQUALS("cppcheck: Failed to load library configuration file ''. File not found\n", logger->str());
+        ASSERT_EQUALS("cppcheck: error: empty library specified.\n", logger->str());
     }
 
     void libraryMultipleEmpty2() {
         REDIRECT;
         const char * const argv[] = {"cppcheck", "--library=posix,gnu,", "file.cpp"};
         ASSERT_EQUALS(false, parser->fillSettingsFromArgs(3, argv));
-        ASSERT_EQUALS("cppcheck: Failed to load library configuration file ''. File not found\n", logger->str());
+        ASSERT_EQUALS("cppcheck: error: empty library specified.\n", logger->str());
     }
 
     void suppressXml() {