enabled and mitigated readability-const-return-type clang-tidy warn…

…ings

.clang-tidy

@@ -56,7 +56,6 @@ Checks: >
         -portability-std-allocator-const,
         -readability-avoid-const-params-in-decls,
         -readability-braces-around-statements,
-        -readability-const-return-type,
         -readability-container-data-pointer,
         -readability-convert-member-functions-to-static,
         -readability-function-cognitive-complexity,

clang-tidy.md

@@ -126,7 +126,6 @@ Also reports a false positive about templates which deduce the array length: htt
 We run this separately via `clang-include-cleaner` in the `iwyu.yml` workflow as the findings of the include checkers still need to be reviewed manually before applying them. 
 
 `bugprone-branch-clone`<br/>
-`readability-const-return-type`<br/>
 `modernize-return-braced-init-list`<br/>
 `misc-throw-by-value-catch-by-reference`<br/>
 `readability-avoid-const-params-in-decls`<br/>

gui/projectfiledialog.cpp

@@ -772,6 +772,7 @@ void ProjectFileDialog::addSingleSuppression(const Suppressions::Suppression &su
 void ProjectFileDialog::setSuppressions(const QList<Suppressions::Suppression> &suppressions)
 {
     mUI->mListSuppressions->clear();
+    // NOLINTNEXTLINE(readability-const-return-type) - neeeds to be a copy since it might be a reference to mSuppressions
     QList<Suppressions::Suppression> new_suppressions = suppressions;
     mSuppressions.clear();
     for (const Suppressions::Suppression &suppression : new_suppressions) {

gui/test/translationhandler/testtranslationhandler.cpp

@@ -24,7 +24,7 @@
 #include <QStringList>
 #include <QtTest>
 
-static const QStringList getTranslationNames(const TranslationHandler& handler)
+static QStringList getTranslationNames(const TranslationHandler& handler)
 {
     QStringList names;
     for (const TranslationInfo& translation : handler.getTranslations()) {