cmake/versions.cmake: version string must have 3 parts otherwise cmak…

…e might crash
danmar · Jun 27, 2023 · 087bd12 · 087bd12
1 parent 4f71bbe
commit 087bd12
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/cmake/versions.cmake b/cmake/versions.cmake
@@ -1,4 +1,5 @@
 # Version for libraries CPP
+# Version string must have 3 "parts". https://sourceforge.net/p/cppcheck/discussion/development/thread/e57efb2b62/
 SET(VERSION "2.11.99")
 STRING(REGEX MATCHALL "[0-9]+" VERSION_PARTS "${VERSION}")
 LIST(GET VERSION_PARTS 0 VERSION_MAJOR)

diff --git a/createrelease b/createrelease
@@ -31,7 +31,7 @@
 #
 # Update version numbers in:
 # sed -i -r "s/version 2[.][0-9]+([.]99)*/version 2.9/" cli/main.cpp
-# sed -i -r "s|2[.][0-9]+([.]99)*|2.9|" cmake/versions.cmake
+# sed -i -r "s|2[.][0-9]+([.]99)*|2.9.0|" cmake/versions.cmake # version must have 3 parts.
 # sed -i -r "s/MINOR [0-9]+/MINOR 9/" lib/version.h
 # sed -i -r "s/2[.][0-9]+([.]99)*/2.9/" win_installer/productInfo.wxi
 # sed -i -r "s/subtitle: Version 2\.[0-9]+/subtitle: Version 2.9/" man/*.md