Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketch out conj method #46

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

Sketch out conj method #46

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
eeba989
Sketch out conj method
dallonasnes Oct 9, 2023
69d0341
add draft of tn api
danlkv Oct 18, 2023
0d74462
Use np sliced buckets method from qtree
dallonasnes Oct 21, 2023
b0645a2
Update
dallonasnes Oct 22, 2023
d7e24c2
Address comments
dallonasnes Oct 30, 2023
1aafd05
Cleanup
dallonasnes Nov 6, 2023
3533289
progress
dallonasnes Nov 6, 2023
ea2a43c
Bugfixes
dallonasnes Nov 6, 2023
0c91a8f
Progress
dallonasnes Nov 13, 2023
dbeee3d
Progress
dallonasnes Nov 13, 2023
1d7271b
Notes
dallonasnes Nov 13, 2023
0026283
Cleanup
dallonasnes Nov 13, 2023
b48ea18
Progress after meeting
dallonasnes Nov 14, 2023
efbab98
Fix copy so that it is not in place
dallonasnes Dec 4, 2023
1631afb
Stuck
dallonasnes Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions scratchpad/tn_api/tn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
import math
from dataclasses import dataclass
from typing import TypeVar, Generic, Iterable
from qtree import np_framework

class Array(np.ndarray):
shape: tuple[int]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed all instances of tuple[... because was getting error that types can't have [

shape: tuple

D = TypeVar('D') # tensor data type (numpy, torch, etc.)

Expand Down Expand Up @@ -52,16 +53,21 @@ class Port:
class TensorNetwork(TensorNetworkIFC[np.ndarray]):
tensors: Iterable[np.ndarray]
shape: tuple
edges: tuple[tuple[Port]]
edges: tuple

def __init__(self, *args, **kwargs):
self._tensors = []
self._edges = tuple()
self.shape = tuple()
self.buckets = []
self.data_dict = {}

# slice not inplace
def slice(self, slice_dict: dict) -> 'TensorNetwork':
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danlkv thanks for the previous comment, i believed i've addressed that in this update

...
tn = self.copy()
sliced_buckets = np_framework.get_sliced_np_buckets(self.buckets, self.data_dict, slice_dict)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i imagine data_dict needs to be populated for this to be meaningful logic. is that something the callers should pass in? @danlkv

tn.buckets = sliced_buckets
return tn

def copy(self):
new = TensorNetwork()
Expand Down Expand Up @@ -153,4 +159,6 @@ def __repr__(self):




if __name__ == "__main__":
tn = TensorNetwork.new_random_cpu(2, 3, 4)
import pdb; pdb.set_trace()
Loading