Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression #41

Open
wants to merge 159 commits into
base: dev
Choose a base branch
from
Open

Compression #41

wants to merge 159 commits into from

Conversation

danlkv
Copy link
Owner

@danlkv danlkv commented Jan 14, 2023

  • Cost estimation takes into account number of (de)compressions, memory limit, etc.
    Usage: compressed_contraction_cost(tn, peo, mem_limit, compression_ratio)
    Memory limit is assumed to be log2(number of elements) = log2(number of bytes/16)
  • Cost estimation example qtensor/compression/test_cost_estimation.py

@danlkv
Copy link
Owner Author

danlkv commented Feb 10, 2023

@mkshah5
I'm trying to build sz compression as described in README_python.md.

I get the following error:

DynamicByteArray.c:13:10: fatal error: DynamicByteArray.h: No such file or directory
   13 | #include "DynamicByteArray.h"
      |          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

I found the file in the main SZ repo (sz/include dir). I tried cloning the repo and passing -I ../SZ/sz/include flag but it is giving more errors:

sz_p_q.c:284:9: error: unknown type name ‘TightDataPointStorageD’
  284 |         TightDataPointStorageD* tdps;
      |         ^~~~~~~~~~~~~~~~~~~~~~
sz_p_q.c:286:9: warning: implicit declaration of function ‘new_TightDataPointStorageD’ [-Wimplicit-function-declaration]
  286 |         new_TightDataPointStorageD(&tdps, dataLength, exactDataNum,
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
sz_p_q.c:287:48: error: request for member ‘array’ in something not a structure or union
  287 |                         type, exactMidByteArray->array, exactMidByteArray->size,
      |                                                ^~
sz_p_q.c:287:74: error: request for member ‘size’ in something not a structure or union
  287 |                         type, exactMidByteArray->array, exactMidByteArray->size,
      |                                                                          ^~
sz_p_q.c:288:42: error: request for member ‘array’ in something not a structure or union
  288 |                         exactLeadNumArray->array,
      |                                          ^~
sz_p_q.c:289:37: error: request for member ‘array’ in something not a structure or union
  289 |                         resiBitArray->array, resiBitArray->size,
      |                                     ^~
sz_p_q.c:289:58: error: request for member ‘size’ in something not a structure or union
  289 |                         resiBitArray->array, resiBitArray->size,
      |                                                          ^~
sz_p_q.c:292:9: error: request for member ‘plus_bits’ in something not a structure or union
  292 |     tdps->plus_bits = confparams_cpr->plus_bits;
      |         ^~
sz_p_q.c:295:9: warning: implicit declaration of function ‘free_DIA’ [-Wimplicit-function-declaration]
  295 |         free_DIA(exactLeadNumArray);
      |         ^~~~~~~~
sz_p_q.c:302:9: warning: implicit declaration of function ‘freeTopLevelTableWideInterval’ [-Wimplicit-function-declaration]
  302 |         freeTopLevelTableWideInterval(&levelTable);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sz_p_q.c: At top level:
sz_p_q.c:308:151: error: unknown type name ‘bool’
  308 |                                                                                                                                 unsigned char* signs, bool* positive, double min, double max, double nearZero){
      |                                                                                                                                                       ^~~~
sz_p_q.c:5:1: note: ‘bool’ is defined in header ‘<stdbool.h>’; did you forget to ‘#include <stdbool.h>’?
    4 | #include <math.h>
  +++ |+#include <stdbool.h>
    5 | void updateLossyCompElement_Double(unsigned char* curBytes, unsigned char* preBytes,
sz_p_q.c:341:137: error: unknown type name ‘bool’
  341 | double computeRangeSize_double_MSST19(double* oriData, size_t size, double* valueRangeSize, double* medianValue, unsigned char * signs, bool* positive, double* nearZero)
      |                                                                                                                                         ^~~~
sz_p_q.c:341:137: note: ‘bool’ is defined in header ‘<stdbool.h>’; did you forget to ‘#include <stdbool.h>’?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants