Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Azure Eventhubs returns list duplicated servers #448

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

nqminhdl
Copy link

I'm using kafka-exporter to monitor Azure Event Hubs and connect successfully with below flags

./kafka_exporter \
    --kafka.server='<eventhub-namespace>.servicebus.windows.net:9093' \
    --sasl.enabled \
    --sasl.mechanism='plain' \
    --sasl.username='$ConnectionString' \
    --sasl.password='Endpoint=sb://<eventhub-namespace>.servicebus.windows.net/;SharedAccessKeyName=<redacted>;SharedAccessKey=<redacted>=' \
    --tls.enabled \
    --tls.insecure-skip-tls-verify \
    --log.level=debug \
    --verbosity=1 \
    --kafka.version=1.0.0

With latest release 1.7.0, I have the same issue as described in this issue #349

collected metric "kafka_consumergroup_members" { label:<name:"consumergroup" value:"delivery-*" > gauge:<value:2 > } was collected before with the same name and label values
collected metric "kafka_consumergroup_members" { label:<name:"consumergroup" value:"cashier-*" > gauge:<value:2 > } was collected before with the same name and label values
collected metric "kafka_consumergroup_members" { label:<name:"consumergroup" value:"delivery-*" > gauge:<value:2 > } was collected before with the same name and label values

This PR is to handle the case for Azure Event Hubs returns new servers with different upper case characters after RefreshMetadata.

@nqminhdl
Copy link
Author

Hi @danielqsj,

Can you help to review this PR?
Thanks!

@nqminhdl
Copy link
Author

Hi @danielqsj,

Can you help to review this PR?
Thanks!

@danielqsj
Copy link
Owner

LGTM,thanks @nqminhdl

@danielqsj danielqsj merged commit 7b5bef3 into danielqsj:master Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants