Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add components overview #810

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Granjow
Copy link
Contributor

@Granjow Granjow commented Apr 14, 2021

This documentation PR adds a short overview over some main components which are available in Workflow Core. Having a bigger picture or architecture view was something I missed when starting with Workflow Core.

I'd prefer something like a C4 components diagram, but readthedocs seems to be limited with diagram options.

Any suggestions/ideas?

Copy link
Owner

@danielgerlag danielgerlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the target audience consumers of workflow core or contributors to the library itself?


## Persistence

The persistence provider persists the state of a workflow instance with execution pointers. They are created when visiting a step while executing a workflow and hold information about their outcome.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think execution pointers are more of an internal concept, not really specific to persistence?
Either way, I'm not sure this paragraph gives a description of what they are.

@@ -114,6 +114,16 @@ Console.ReadLine();
host.Stop();
```

## Registry

The workflow host keeps workflow definitions in the registry when they are registered. When starting a workflow, the workflow host creates a new instance for the desired workflow definition.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow host does not keep the definitions, the registry does, the workflow host accesses the registry.

@Granjow
Copy link
Contributor Author

Granjow commented Jun 9, 2021

@danielgerlag Thanks for your review, I have updated the pull request. Better now?

Target audience is mainly consumers of the library, but I have found it easier to work with Workflow Core when also understanding some of the more internal concepts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants