Skip to content
This repository has been archived by the owner on Nov 14, 2020. It is now read-only.

Updates #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updates #38

wants to merge 4 commits into from

Conversation

bradmartin
Copy link
Contributor

  • Update the platforms dirs
  • Bump android SDK
  • Add typings dir to npmignore
  • Improve the captureException method in the android.ts file to include the stack/message in a better way. Still some work to be done regarding sourcemaps but now the Exception should contain decent info, has been losing context for a while

@bradmartin
Copy link
Contributor Author

This is a breaking change to NS 6.2+ so might go ahead and bump the major

@danielgek
Copy link
Owner

@bradmartin thanks for the update ❤️ i will look into release this asap

@bradmartin
Copy link
Contributor Author

It doesn't have to be breaking actually, if the NS webpack.config has the alias to use the older tns-core-modules and not the @nativescript/core packages for imports. Just need to check if that is provided by default by the NS webpack.config, if it is then this is not breaking and just uses the newer package naming convention 👍

@bradmartin
Copy link
Contributor Author

I updated the exception for android because lately it seems that a lot of exceptions aren't actually providing any info to Sentry when they were logged. The throwable would be null providing no context or what the issue was. So far I've used this approach in a project and it seems to work much more reliably. Still would like to get sourcemap support for sentry but that's probably going to be needing the Sentry teams help.

@bradmartin
Copy link
Contributor Author

bradmartin commented Jan 14, 2020

@danielgek any chance you can get to this? Also, I've recently been using Github Actions for CI and have working yml files if you want, I'd be happy to help get that integrated on this repo in a PR. You can see a working one in the lottie plugin here. Should be able to copy some of the npm scripts from the travis file if you have testing or anything configured and just add a step to what I have there. So far I'm loving Actions over Travis just bc the YML file is much cleaner to configure everything.

@danielgek
Copy link
Owner

@bradmartin go over the nativescript slack

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants