-
Notifications
You must be signed in to change notification settings - Fork 58
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Mega grabbag PR
- Loading branch information
Showing
34 changed files
with
1,060 additions
and
1,557 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| ### How do debug agenda | ||
|
|
||
| Edit `now.staging.json` to include `DEBUG` | ||
|
|
||
| ```diff | ||
| { | ||
| "env": { | ||
| + "DEBUG": "agenda:*" | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| You can throw up a UI to the db using: | ||
|
|
||
| ```sh | ||
| echo "http://localhost:3001"; npx agendash --db=[get this from .env] --collection=agendaJobs --port=3001 | ||
| ``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,7 +86,7 @@ describe("for PRs", () => { | |
| ]) | ||
| }) | ||
|
|
||
| it("returns many runs when there are mutliple potential matches", () => { | ||
| it("returns many runs when there are multiple potential matches", () => { | ||
| const rules = { | ||
| issue: "dangerfile.js", | ||
| pull_request: "dangerfile.js", | ||
|
|
@@ -114,6 +114,28 @@ describe("for PRs", () => { | |
| ]) | ||
| }) | ||
|
|
||
| it("prefixes the repo when that's passed in", () => { | ||
| const rules = { | ||
| "issue.created, issue.closed": "dangerfile.js", | ||
| pull_request: "dangerfile.js", | ||
| } | ||
|
|
||
| expect( | ||
| dangerRunForRules("pull_request", "created", rules, {}, "danger/olives").map(m => m.referenceString) | ||
| ).toEqual(["danger/[email protected]"]) | ||
| }) | ||
|
|
||
| it("doesn't prefix the repo when that's passed in and has a repo reference", () => { | ||
| const rules = { | ||
| "issue.created, issue.closed": "dangerfile.js", | ||
| pull_request: "danger/[email protected]", | ||
| } | ||
|
|
||
| expect( | ||
| dangerRunForRules("pull_request", "created", rules, {}, "danger/olives").map(m => m.referenceString) | ||
| ).toEqual(["danger/[email protected]"]) | ||
| }) | ||
|
|
||
| it("returns null when no multi inline rules match", () => { | ||
| const rules = { | ||
| "issue.created, pull_request.closed": "dangerfile.js", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.