Convert configuration page to SFC #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirlgon
force-pushed
the
configuration_to_vue3
branch
3 times, most recently
from
0b70b02
to
7cf7475
Compare
pgiraud
reviewed
Jul 9, 2024
pirlgon
force-pushed
the
configuration_to_vue3
branch
from
7cf7475
to
5bba1f0
Compare
|
Lorsque je met une valeurs hors limites, dans l'agent: Ça finit comme ça dans l'UI:
Pas fou. |
bersace
reviewed
Jul 10, 2024
bersace
reviewed
Jul 10, 2024
pirlgon
force-pushed
the
configuration_to_vue3
branch
4 times, most recently
from
6dfba5e
to
0f275f7
Compare
We include js and css in Configuration.vue and remove the old files. Jquery is now imported from the npm package.
pirlgon
force-pushed
the
configuration_to_vue3
branch
from
0f275f7
to
8f053a6
Compare
pirlgon
force-pushed
the
configuration_to_vue3
branch
from
8f053a6
to
361cdb6
Compare
bersace
approved these changes
Jul 16, 2024
bersace
reviewed
Jul 16, 2024
bersace
reviewed
Jul 16, 2024
pirlgon
force-pushed
the
configuration_to_vue3
branch
from
361cdb6
to
3fbfedc
Compare
bersace
approved these changes
Jul 16, 2024
pgiraud
reviewed
Jul 16, 2024
Comment on lines
12
to
15
| current_cat="{{ current_cat }}" | ||
| error_message="{{ error_message }}" | ||
| error_code="{{ error_code }}" | ||
| query_filter="{{ query_filter if query_filter else '' }}" |
There was a problem hiding this comment.
Conventionaly, it's better to use kebab-case for props (in the template) to align with HTML attributes.
https://vuejs.org/guide/components/props.html#prop-name-casing
|
|
||
| import Error from "../components/Error.vue"; | ||
|
|
||
| const props = defineProps(["current_cat", "error_message", "error_code", "query_filter", "address", "port"]); |
There was a problem hiding this comment.
By convention, it's better to use camelCase for props names.
https://vuejs.org/guide/components/props.html#prop-name-casing
| }); | ||
| <script type="module" src="{{ vitejs.url_for('pgconf.js') }}"></script> | ||
| <script type="text/javascript"> | ||
| var data = { |
There was a problem hiding this comment.
data is a very generic name prone to conflicts. What about configurationData?
| <div class="col-3 mr-auto"> | ||
| <form | ||
| method="get" | ||
| :action="'/server/' + address + '/' + port + '/pgconf/configuration'" |
There was a problem hiding this comment.
:action="`/server/${address}/${port}/pgconf/configuration`"
This notation could be use in a few other places.
| content += | ||
| `<tr><td>Minimum:</td><td><b>${row["min_val"]}</b></td></tr>` + | ||
| `<tr><td>Maximum:</td><td><b>${row["max_val"]}</b></td></tr>`; | ||
| let url = ""; |
There was a problem hiding this comment.
For me, it would be easier to read with:
let url = `/proxy/${props.address}/${props.port}/pgconf/configuration`
...
if (queryFilter.value == "") {
url += `/category/${quotePlus(currentCat.value)}`;
}| content += `<tr><td>Unit:</td><td><b>${row["unit"]}</b></td></tr>`; | ||
| function getCategories() { | ||
| $.ajax({ | ||
| url: "/proxy/" + props.address + "/" + props.port + "/pgconf/configuration/categories", |
There was a problem hiding this comment.
The template string notation would probably fit here and in a few other locations.
| }, | ||
| error: function (xhr) { | ||
| modalLoading.value = false; | ||
| error.value.fromXHR(xhr); | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| function parsedEnumVals(enumString) { | ||
| let trimmed = enumString.replace(/^\{|\}$/g, ""); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We include js and css in Configuration.vue
and remove the old files.
Jquery is now imported from the npm package.