-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap5 #1434
Bootstrap5 #1434
Conversation
82cf642
to
45a3da1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le découpage des commits est excellent, j'aurai préféré bs5:
comme préfixe de message de commit, ça me semble plus cohérent avec le reste. ou ui(bs5):
.
61ee630
to
082f0c1
Compare
1bf944b
to
64c523f
Compare
cad615a
to
fea520d
Compare
cf. #1457 |
Bootstrap a fait le choix de souligner les liens. |
Effectivement, je n'étais pas à jour. J'ai dû rater quelque chose. Désolé ! |
Bug introduced in 999a9bf
Instead of relying on CSS class, we select first column.
Use bg- instead
For an unknown reason Bootstrap uses a black font when the background is set with this success color. It may not be dark enough for BS to decide to switch to white font.
Use grid system instead
It's required for the position-absolute in children to work properly.
In maintenance pages, there's no popover apparently, so no need to enable them.
The resulting rendering is different from what we had in BS4.
This fixes the missing space between sidebar and main element when switching to BS5.
Display switch value next to checkbox.
No description provided.