refactor: use ignore
crate for matching gitignore patterns
#341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #337 and #2
The benchmark comparing ambs 0.6 with this branch:
I think it's a reasonable regression in performance considering the new implementation respects the full scope of gitignore syntax.
The ignore crate also provides
Walk
which can perform the task of traversing the file tree while respecting the gitignores. It is based on walkdir internally. That might provide additional performance benefits if implemented in the future.