[rfc] Support partitions in add_output_metadata #26562
Open
+85
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dpeng817
changed the title
OwenKephart
requested changes
Dec 18, 2024
| metadata=metadata, | ||
| output_name=output_name, | ||
| mapping_key=mapping_key, | ||
| asset_partition_key=partition_key, |
There was a problem hiding this comment.
why partition_key above and asset_partition_key here?
I think just using partition_key everywhere makes sense
There was a problem hiding this comment.
I kept it as asset_partition_key here to make it clear that this is only really applicable to asset events, and not to partitioned ops for example
dpeng817
force-pushed
the
output_metadata_refactor
branch
from
aab7bd1 to
298f9ae
Compare
dpeng817
force-pushed
the
dpeng817/partitioned_output_metadata
branch
from
39b5894 to
674a249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR attempts support at specifying metadata at the partition level for outputs. The use case here is that if you're materializing many partitions in the same computation, you might want to specify different metadata for each processed partition.
I explicitly made a change which makes this work on assets and not ops, since I think the use case is less valid in op-land. But we can discuss whether that's something worth supporting.
How I Tested These Changes
Added to an existing test which operates over partition ranges. Shows the behavior when specifying metadata on the partition level and the non-partition level, and shows that the metadata gets combined on the partitioned materialization in the end.