Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-622 clean up Hybrid docs and add architecture diagram #26549

Merged
merged 9 commits into from
Dec 18, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Dec 17, 2024

Summary & Motivation

*Updates hybrid deployment index page to focus on setup and architecture page to focus on architecture

  • Reorganizes agents in sidebar to match ordering on index page
  • Adds architecture diagram

How I Tested These Changes

Local deployment.

Changelog

Insert changelog entry or delete this section.

@neverett neverett self-assigned this Dec 17, 2024
@neverett neverett added the area:docs-revamp Related to the revamp of the docs label Dec 17, 2024
- No ingress is required from Dagster+ to user environments
- Dagster+ doesn't have access to user code. Metadata about the code is fetched over constrained APIs.
- The Dagster+ agent is [open source and auditable](https://github.com/dagster-io/dagster-cloud)
Common security considerations in Dagster+ hybrid include:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these recommendations for the user to follow? If so, I'll move them to the index page for the hybrid section (which is basically the setup page).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they are

Copy link

github-actions bot commented Dec 17, 2024

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-9co78zpoh-elementl.vercel.app

Direct link to changed pages:

@neverett neverett requested review from cmpadden and dehume December 17, 2024 19:47
Copy link
Contributor

@dehume dehume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new diagram looks great

@neverett neverett merged commit d033459 into master Dec 18, 2024
2 of 3 checks passed
@neverett neverett deleted the nikki/docs/hybrid-docs branch December 18, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs-revamp Related to the revamp of the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants