[record] defend against problematic collisions #22860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alangenfeld and the rest of your teammates on |
alangenfeld
force-pushed
the
al/07-05-_record_defend_against_problematic_collisions
branch
from
c3ed036
to
b6f9fd1
Compare
OwenKephart
approved these changes
Jul 8, 2024
alangenfeld
force-pushed
the
al/07-05-_record_defend_against_problematic_collisions
branch
from
b6f9fd1
to
25a2e1f
Compare
alangenfeld
force-pushed
the
al/07-05-_record_defend_against_problematic_collisions
branch
from
25a2e1f
to
3a779d1
Compare
alangenfeld
deleted the
al/07-05-_record_defend_against_problematic_collisions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped in to this in #22855, its confusing (and breaks default resolution) to have record fields conflict with methods so defend against it.
How I Tested These Changes
added test