[ui] Refactor RunTable into more reusable components #22841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengotow
force-pushed
the
bengotow-2024-07/FE-438-grouped-runs
branch
from
494bc03
to
d416ee0
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit edd0bdc. |
bengotow
force-pushed
the
bengotow-2024-07/FE-438-grouped-runs
branch
from
d416ee0
to
edd0bdc
Compare
salazarm
reviewed
Jul 8, 2024
|
|
||
| import {AnchorButton} from '../ui/AnchorButton'; | ||
|
|
||
| export const RunTableEmptyState = ({anyFilter}: {anyFilter: boolean}) => { |
salazarm
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR doesn't include any functionality changes - the experimental grouped runs page will require a separate version of the RunTable and RunRow with a new design, and the changes here make it easier to re-use the bulk of the complexity in these existing components by breaking them out into smaller components. 🙏
How I Tested These Changes
Test that hovering over run tags, opening run tag modal, adding tag to filter, etc. all still work and that the run table is visually unchanged.