-
-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing windows extensions #1390
base: master
Are you sure you want to change the base?
Conversation
I had no idea Windows even supports jekyll development! I'm a windows user but always assume anything I have to do has to happen on WSL on a remote server... After looking at the docs, I see they recommend using the line |
Hm, I don't know how to do conditional deps. Total n00b on this. I just run jekyll ;) |
I prefer not to modify sensitive files if we don't fully understand the impact. Modifying html/css/js files is easy, but anything to do with ruby I try to be very cautious about. If you test this on Unix and verify that it works , let me know. |
Fixed with recommended suggestions! Run install/exec on WSL2 Ubuntu and it worked great too. |
64d16cf
to
97e28c9
Compare
I'm not sure why there are so many files changed in this PR |
I think something was accidentally included in the last force push. |
Yep, fixing it now, sorry! |
When running on Windows, wdm is required in order to properly do incremental updates and regeneration. Fix dependency on timezone to match docs See https://jekyllrb.com/docs/installation/windows/#time-zone-management
The indentation seems to be off (there's extra spaces in a few lines). I'm not sure if these lines would also need to be included in the gemspec file, or does it make sense to only include them in the Gemfile? @ReenigneArcher do you have insight on this? |
I don't have a ton of experience with ruby other than a little with this project and one other homebrew spec, but I found this blog post on the topic. https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ That seems to suggest the dependencies should be defined in the gemspec file versus the Gemfile. Additionally with the gemspec file they can be properly specified as dev dependencies. I guess the syntax will be slightly different though. spec.add_runtime_dependency "wdm", "~> 0.1.1", install_if: Gem.win_platform?
# Windows and JRuby does not include zoneinfo files, so bundle the tzinfo-data gem and associated library.
spec.add_runtime_dependency "tzinfo", ">= 1", "< 3", platforms: [:mingw, :x64_mingw, :mswin, :jruby]
spec.add_runtime_dependency "tzinfo-data", platforms: [:mingw, :x64_mingw, :mswin, :jruby] |
I read that as well, which is what made me question where this should be added. I'm going to install windowsruby myself and try this out and experiment. But I'll also post on a jekyll forum to get advice from people who have much more experience. I'm going to refrain from accepting this PR until know for sure that it's correct. |
I've spent a lot of time researching this, and I think the issue you're having is only when you clone this repository and try to run a jekyll site using the direct files in this repo, is that correct? If you use the theme using using |
When using |
Before I finalize this, I asked on Jekyll forum and on SO, and I want to give it a few days to see if someone thinks my reasoning is wrong. |
Yes, I think this is mostly for the case of someone contributing to this repo or forking to make changes (as I did). :) |
When running on Windows, wdm is required in order to properly do incremental updates and regeneration.
The tzinfo-data dependency is also reported missing (under Windows at least, with jekyll 3.9.3).