Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies #471

Merged

Conversation

XiNiHa
Copy link
Contributor

@XiNiHa XiNiHa commented Jul 2, 2024

  • ESLint is excluded from major bump since typescript-eslint v8 that supports ESLint v9 is still not released as stable.

Copy link

changeset-bot bot commented Jul 2, 2024

⚠️ No Changeset found

Latest commit: 367a62e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ❌ Failed (Inspect) Jul 7, 2024 3:01pm

Copy link

vercel bot commented Jul 2, 2024

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

Copy link
Member

@tonyfromundefined tonyfromundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @XiNiHa! .nvmrc is currently set to version 16, but it seems like this part is out of sync. After discussing it internally, we decided that it would be better to delete .nvmrc. Could you please apply that part?

@XiNiHa
Copy link
Contributor Author

XiNiHa commented Jul 8, 2024

Done! BTW, while removing the Node 16 requirement, I also updated CONTRIBUTING.md to state that only maintained Node versions are supported. Therefore it should be confirmed whether that matches what other maintainers are also thinking about.

Copy link
Member

@tonyfromundefined tonyfromundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyfromundefined
Copy link
Member

FYI: VSCode 1.19.1 is required for TypeScript Language Service

@tonyfromundefined
Copy link
Member

tonyfromundefined commented Jul 17, 2024

@XiNiHa A simple version bump happened and it caused a conflict. 😅 Can you resolve this conflict?

@XiNiHa
Copy link
Contributor Author

XiNiHa commented Jul 17, 2024

@tonyfromundefined Done!

@tonyfromundefined tonyfromundefined merged commit 26ffe6d into daangn:main Jul 18, 2024
3 of 4 checks passed
@XiNiHa XiNiHa deleted the chore/upgrade-deps branch July 18, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants