Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update class.php #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dustsucker
Copy link

Fixed Virtual Pages content Translation Issue

class.php changed:
$this->_setPageLanguage($page, $languageCode, false); to $this->_setPageLanguage($page, $languageCode);
as it now properly sets the languages for Virtual Pages

Description/Motivation

So I Stumbled upon a Problem generation our Multipage project. We have a few Plugins That use Virtual Pages and Multi Language Support now I created a script to load the Pages into the static site generator. It works fine, but the Translations didn't seem to work. I debugged a little bit and this was the first working version.

Testing

So I just tested it With a Script and Custom Routes.

Related issue

New

Fixed Virtual Pages content Translation Issue
@dustsucker dustsucker marked this pull request as draft July 10, 2024 10:45
@dustsucker
Copy link
Author

I found a page where the fix does not work.

@dustsucker dustsucker marked this pull request as ready for review July 10, 2024 10:52
@dustsucker
Copy link
Author

The not Page where it was not fixed was a fluke. It was cached and now it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant